search

sensepost / gowitness

🔍 gowitness - a golang, web screenshot utility using Chrome Headless
GNU General Public License v3.0
2.87k stars 329 forks source link

Fix Chrome Hangs Using Chromedp Timed Context #132

Closed ghost closed 2 years ago

ghost commented 2 years ago

This PR supersedes #129, which addresses #116.

While most of the work was already done by @randomactsofsecurity in #129, this PR is now compatible with the current state of master. All details about the implementation can be found in #129.

The commits contain attribution for @randomactsofsecurity.

randomactsofsecurity commented 2 years ago

Does this PR change or identify any bugs from #129? I didn't rebase that PR yet since I wanted to make sure other's tested it out.

ghost commented 2 years ago

This PR only refines the refactoring (more explicit naming for cancel functions, ...) and was rebased onto the current state of master. It does not change the general functionality of #129.

However, I was experiencing regular hangups with the current master branch and #129 as well as this PR appear to fix it.

randomactsofsecurity commented 2 years ago

That's fair, I've probably screwed up the rebase history enough on my original PR that it makes sense to use this one anyway. In the future, it may be good to pull from my original branch for this type of rebase rather than doing the 'co-author' route so that the attribution/history remains the same

leonjza commented 2 years ago

Sorry for taking time to respond here. I'll give these a test soon and prepare a next release!

leonjza commented 2 years ago

Sorry for the time it took to land this PR, but thank you both @rtpt-jonaslieb and @randomactsofsecurity for your contribution!