sensepost / objection

📱 objection - runtime mobile exploration
GNU General Public License v3.0
7.46k stars 854 forks source link

Streamlining error handling when --skip-resources is set #374

Closed mtschirs closed 4 years ago

mtschirs commented 4 years ago

objection patchapk currently does not work well when --skip-resources is set. Especially since the addition of --ignore-nativelibs, objection patchapk does not work at all with --skip-resources unless --ignore-nativelibs is set.

In order to improve the situation somewhat, objection patchapk now handles a missing --ignore-nativelibs similar to a given --enable-debug and prints an incompatibility warning. Also, the check for skip_resources within AndroidPatcher has been moved into the _get_android_manifest function to avoid checks all over the place.

leonjza commented 4 years ago

Neat thanks!