sensepost / objection

📱 objection - runtime mobile exploration
GNU General Public License v3.0
7.46k stars 854 forks source link

Handle additional sslpinning varieties #475

Open thgoebel opened 3 years ago

thgoebel commented 3 years ago

Is your feature request related to a problem? Please describe. To make android sslpinning disable work for this app I had to change this line: https://github.com/sensepost/objection/blob/c2121af4944b44220f56a56fd283334aff9f6b16/agent/src/android/pinning.ts#L144 to:

const CertificatePinnerCheckOkHttp = certificatePinner.check$okhttp.overload("java.lang.String", "kotlin.jvm.functions.Function0");

Describe the solution you'd like I suspect other non-obfuscated Kotlin apps will require a similar change. However there are already two big function blocks just for okhttp, so adding a third one doesn't feel right.

So this issue is somewhat a meta question: to what extend to you want to include/support all these different function signatures? And how? By replicating a lot of code, or introducing another level of abstraction somewhere?

Describe alternatives you've considered Add a third okHttp3CertificatePinnerCheckXYZ function.

Additional context n/a