[bug] Why Internet Permission is required in script mode

[harshitshah4]

• Please, fill in all of the sections in this template.
• Please read each section carefully. Each has a description of what information will help.
• Windows support is limited. There is a good chance that a pull request would help!
• The more information you give, the better.
• Remove this section when you are done.

Describe the bug A clear and concise description of what the bug is. So when patching the apk with script it should ideally not check for injecting internet permission right ? gadget's config.json file also has interaction type as "script". My understanding is we need to inject internet permission in "listen" mode, where we need to interact with frida's gadget via cli using usb debugging.

To Reproduce Steps to reproduce the behavior:

1. objection patchapk --script-source /path/to/script.json --gadget-config /path/to/config.json --architecture

Similar issues Please link the issues in this repository that is similar to yours.

For example: #358, #229 etc.

Expected behavior Since Frida Gadget requires to have internet permission in order to open socket, this helps debugging helps via cli, when running in "listen" mode, but since in "script" mode, we don't require internet permission, objection shouldn't try to insert or look for Internet Permission in AndroidManifest.xml. A clear and concise description of what you expected to happen.

Evidence / Logs / Screenshots After running the above command following logs are generated:

Any output from objection, such as stack traces or errors that occurred. Be sure to run objection with the --debug flag so that errors from the agent are verbose enough to debug. For example:

objection --debug explore

Environment (please complete the following information):

• Device: Used without connecting any device
• OS: Android
• Frida Version 15.1.17
  • Objection Version 1.11.0

Application If possible, please attach the target application where you can reproduce this bug to the issue.

Additional context Add any other context about the problem here.

[leonjza]

Yeah, technically we don't need the permission for script mode, but it's not something I think we'll change now. The patcher will change soon when we rely on the Frida provided injection capability soon anyways.

[harshitshah4]

@leonjza What is this capability provided by Frida? Do you mean jdwp? Wouldn't that require making the app debuggable ? Some apps might not work in that case. Since quite few apps behave different when ran in debug mode.