sensepost / objection

📱 objection - runtime mobile exploration
GNU General Public License v3.0
7.17k stars 825 forks source link

[bug] Running patchapk results in IO value error #629

Open khairm opened 11 months ago

khairm commented 11 months ago

Describe the bug When I run objection patchapk -s Twitter.apk I get ValueError: I/O operation on closed file

To Reproduce Steps to reproduce the behavior:

  1. Run command '...'

Expected behavior I am expecting a rebuild of the apk that has SSL pinning disabled

Evidence / Logs / Screenshots Any output from objection, such as stack traces or errors that occurred. Be sure to run objection with the --debug flag so that errors from the agent are verbose enough to debug. For example:

objection --debug explore

No architecture specified. Determining it using adb... Detected target device architecture as: arm64-v8a Using latest Github gadget version: 16.1.3 Patcher will be using Gadget version: 16.1.3 Detected apktool version as: 2.8.1 Running apktool empty-framework-dir... I: Removing 1.apk framework file... Unpacking Twitter.apk Exception in thread Thread-10 (_readerthread): Traceback (most recent call last): File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\threading.py", line 1016, in _bootstrap_inner self.run() File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\threading.py", line 953, in run self._target(*self._args, self._kwargs) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1497, in _readerthread buffer.append(fh.read()) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\encodings\cp1252.py", line 23, in decode return codecs.charmap_decode(input,self.errors,decoding_table)[0] UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 3744: character maps to Traceback (most recent call last): File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main return _run_code(code, main_globals, None, File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code exec(code, run_globals) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\Scripts\objection.exe__main.py", line 7, in File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\click\core.py", line 1130, in call return self.main(*args, kwargs) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\click\core.py", line 1055, in main rv = self.invoke(ctx) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\click\core.py", line 1657, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\click\core.py", line 1404, in invoke return ctx.invoke(self.callback, ctx.params) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\click\core.py", line 760, in invoke return callback(*args, kwargs) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\objection\console\cli.py", line 373, in patchapk patch_android_apk(**locals()) File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\objection\commands\mobile_packages.py", line 192, in patch_android_apk patcher.inject_internet_permission() File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\objection\utils\patchers\android.py", line 428, in inject_internet_permission if internet_permission in self._get_appt_output(): File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\objection\utils\patchers\android.py", line 317, in _get_appt_output self.aapt = o.out File "C:\Users\khair\AppData\Local\Programs\Python\Python310\lib\site-packages\delegator.py", line 126, in out self.__out = self.std_out.read() ValueError: I/O operation on closed file. Cleaning up temp files...

Environment (please complete the following information):

Application Github not allowing that file type

Additional context Just want to remove ssl pinning. I don't think I installed Frida.... I thought Objection packaged what it needed.

gpearson100 commented 8 months ago

Having the same issue. Any ideas? Thx