senseyeio / roger

Golang RServe client. Use R from Go
MIT License
272 stars 34 forks source link

unsupported rserve version #25

Open bfallik opened 8 years ago

bfallik commented 8 years ago

Hi,

I recently upgraded roger to address https://github.com/senseyeio/roger/issues/23 but now when I try to connect to our Rserve daemon roger reports:

The version of RServe installed is not officially supported. Please consider upgrading 
to the latest version of RServe.

In terms of the Rserve package version we're using a relatively recent install from cran.rstudio.com. sessionInfo() reports Rserve_1.7-3. I'm relatively new to R but is there some way to install a newer version? What version is required? We don't install a specific version of Rserve so I'm wondering why our recent install is behind Roger's minimum version?

Thanks, brian

bfallik commented 8 years ago

Hmm...

I did a little more digging and I think the version that's available in cran is 1.7-3, which matches our install, but the latest version of rserve is 1.8-4 (https://rforge.net/Rserve/news.html).

Is there a recommended way to install a version of Rserve that's supported by Roger without using cran?

bfallik commented 8 years ago

And, further answering my own question, it seems like this is the recommend installation mechanism:

install.packages("Rserve",,"http://rforge.net/")
dareid commented 8 years ago

Hi, thanks for the issue. I am running with 1.7.3 and do not experience the warning message. In addition, the docker image used in the tests is running 1.7.3. I have added a print out of the RServe version on the docker image in 831ec5fe3aa59fdb7bf7452609d43008d5608d67 for future reference. Maybe there is another factor affecting it? Does it work with 1.8.4?

bfallik commented 8 years ago

@dareid thanks for the quick response.

There may be something else that caused this but I was able to workaround the issue by installing Rserve 1.8-4. Once I updated to roger commit f8fb1838724 I was unable to connect to Rserve running 1.7-3. Once I installed Rserve 1.8-4 from rforge.net the error went away.

I'm happy to provide more information if that helps, just let me know what I can do.

brian

integrii commented 8 years ago

it looks like install.packages("Rserve",,"http://rforge.net/") installs version 1.8.5, but that still gives this error. This is the newest version available right now, but it is unsupported??

dareid commented 8 years ago

@integrii thanks for the additional information. I have updated the tests to use the rforge version by default and it appears like the tests are passing. However, I noticed that if I connected to an incorrect port it incorrectly reported that it was not supported instead of a connection issue, any chance that could be the problem you are seeing?

integrii commented 8 years ago

It has been awhile now, but that might have been it. Thanks for following up!