Missing for loops in sexp.parseSymName() and sexp.parseString() causing vector attributes to be parsed incorrectly

senseyeio / roger

Golang RServe client. Use R from Go

MIT License

272 stars 34 forks source link

Missing for loops in sexp.parseSymName() and sexp.parseString() causing vector attributes to be parsed incorrectly #41

Closed joescharf closed 6 years ago

dareid commented 6 years ago

Amazing thanks @joescharf. Is there any chance you could add some test which demonstrate what you are fixing?

joescharf commented 6 years ago

@dareid ok test added. Basically, if you're returning a class with a numeric slot whose name starts with n then it would conflict and overwrite the names key (which, because of the missing for loop was just returned as n), and cause the vector not parsed correctly because the type assertions to string would fail in parseVectorAttr().

dareid commented 6 years ago

Nice one will get this merged and a new release issued, thanks @joescharf!