search

sensiblecodeio / scraperwiki-python

ScraperWiki Python library for scraping and saving data
https://scraperwiki.com
BSD 2-Clause "Simplified" License
159 stars 67 forks source link

Add verbose option for several sqlite methods. #79

Closed petterreinholdtsen closed 9 years ago

petterreinholdtsen commented 9 years ago

The original classic API provided a verbose option, and this option is used by the lazycache code. In the original API the default was 1, while here I set it to False and ignore its value, to get the lazycache code working.

pwaller commented 9 years ago

Can lazycache be updated instead or is that not an option? I would prefer if there was not unnecessary unused clutter in the API.

I cannot find any non-broken references to lazycache anywhere, can you point me at something to go on?

petterreinholdtsen commented 9 years ago

[Peter Waller]

Can lazycache be updated instead or is that not an option? I would prefer if there was not unnecessary unused clutter in the API.

I'm sure every use of the scraperwiki library can be written to cope with the new set of options in the standalone library.

My goal with this patch was to make sure the code working with the old classic scraperwiki library would work with the standalone library too. I assumed that was a goal of the standalone library. If it isn't, feel free to ignore the proposed patch. :)

I cannot find any non-broken references to lazycache anywhere, can you point me at something to go on?

The version I use is in <URL: http://gitorious.org/nuug/postjournaler >. I do not really see the the point of trying to track down every user of the verbose option. If the standalone library should not support it, I am sure every user can fix their copy without any help from us. :)

Happy hacking Petter Reinholdtsen

petterreinholdtsen commented 9 years ago

[Petter Reinholdtsen]

The version I use is in <URL: http://gitorious.org/nuug/postjournaler >.

And it was copied from

<URL: https://classic.scraperwiki.com/editor/raw/lazycache >.

Happy hacking Petter Reinholdtsen

pwaller commented 9 years ago

My preference is to fix it elsewhere. This is the first case I've heard of where it was a problem. It's unfortunate that we can't fix all of them in one go by updating a library, but it sounds like it isn't too hard for you to fix?

petterreinholdtsen commented 9 years ago

[Peter Waller]

My preference is to fix it elsewhere. This is the first case I've heard of where it was a problem. It's unfortunate that we can't fix all of them in one go by updating a library, but it sounds like it isn't too hard for you to fix?

Sure. I already fixed it by patching my copy of the library. :) My goal is to make sure the scrapers and support libraries can stay as they were on the classic scraperwiki interface, so I add the missing features in the scraperwiki library. :)

Happy hacking Petter Reinholdtsen