search

sensiblecodeio / scraperwiki-python

ScraperWiki Python library for scraping and saving data
https://scraperwiki.com
BSD 2-Clause "Simplified" License
160 stars 69 forks source link

Not Python 3 compatible #81

Closed StevenMaude closed 9 years ago

drj11 commented 9 years ago

An interim approach that I did with https://github.com/drj11/pypng is to keep the code as Python 2 code, but make sure it runs through 2to3 cleanly. distribute has some support for doing this automagically in setup.py (when run on Python3).

StevenMaude commented 9 years ago

Thanks @drj11 for the tip; might ask you for guidance if I get stuck with it.

scraperdragon commented 9 years ago

https://github.com/scraperwiki/scraperwiki-python/pull/83

drj11 commented 9 years ago

The approach we are taking in #83 is to make the same code be both Python 2 and Python 3 compatible (this is not too bad if you target the most recent versions of both Python 2 and Python 3).

pwaller commented 9 years ago

Is this resolved @scraperdragon?

StevenMaude commented 9 years ago

This is done; PR was merged a while ago.