sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

remove RenderManagerBackends.h or write it by hand for all platforms #137

Closed JeroMiya closed 8 years ago

JeroMiya commented 8 years ago

There should be no generated header files included by client applications that are platform specific. The same set of headers for RenderManager and OSVR-Core should work for all platforms - the developer need only link against the appropriate binary.

Preferred solution is to go the route of what was done in the export headers (previously generated by cmake, now hand-written to work on all platforms). Instead of generating the header at cmake time, use the same logic the export headers do to define the flags at compile time of the client application.

rpavlik commented 8 years ago

This header is apparently not installed by CMake, thus not included in the built artifacts, thus breaking the build of the Unity rendering plugin ATM.

JeroMiya commented 8 years ago

Implemented in https://github.com/sensics/OSVR-RenderManager/pull/138

russell-taylor commented 8 years ago

Handled in a recent pull request. 26906c1bb2f13009e02c96b5db4bc3f78f862cba