search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

Replace #ifdef and such for _WIN32 with #140

Closed russell-taylor closed 8 years ago

russell-taylor commented 8 years ago

include <osvr/Util/PlatformConfig.h>

if defined(OSVR_WINDOWS)

rpavlik commented 8 years ago

Actually, let's rather not - ifdef _WIN32 is standard and universal, while the other is a platform-dependent generated header.

russell-taylor commented 8 years ago

So... then why do we have the other one? I assumed that we should be using OSVR-defined things within OSVR. Glad to switch things back to _WIN32.

godbyk commented 8 years ago

Question: Should we modify the standard OSVR_{platform} macros to operate at compile-time instead of configure-time?

rpavlik commented 8 years ago

I don't remember why you added that header, Kevin. Perhaps git can tell us.

If we keep it a shipped, public header, it's preferable to be compile time rather than configure time, yes.

russell-taylor commented 8 years ago

Put them back to _WIN32 in dcc4f222b6413379b18d8f6361d92792aff45e1d