search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

OSVRDisplayConfiguration::activeResolution() return by copy #182

Open godbyk opened 8 years ago

godbyk commented 8 years ago

Can we have OSVRDisplayConfiguration::activeResolution() return a copy of the Resolution?

Right now I have to instantiate a const copy of the OSVRDisplayConfiguration on the stack just to call activeResolution() so I can inspect the Resolution.

I don't want to change the resolution, just see what it's set to. My usual instantiation of OSVRDisplayConfiguration is copied to a non-const member variable. So I can't call activeResolution() on that because the non-const version of that member function is private.

russell-taylor commented 8 years ago

I don't recognize any of those calls, so maybe this should be an issue for Core?

russell-taylor commented 8 years ago

Or is this one of the structures I copied into RenderManager to fix and haven't put back yet? If so, go ahead and change it.