search

sensics / OSVR-RenderManager

Apache License 2.0
63 stars 45 forks source link

Remove SDL2_FOUND requirement for OpenGL build #192

Open JeroMiya opened 8 years ago

JeroMiya commented 8 years ago

Currently if you don't have SDL2_FOUND set the OpenGL implementation is not built in. The initial Android build will be without SDL2 (our priority use cases, Unity, Unreal, and simple Android apps that don't use SDL2, all don't need SDL2 and will be using the custom toolkit approach instead).

Aside from just getting cmake to include the OpenGL sources, we need to wrap any SDL2 dependent code with checks for SDL2_FOUND. With no SDL2_FOUND, opening the display without passing in a custom toolkit should result in a failure.

russell-taylor commented 7 years ago

Fixed in commit 0e2d6845e8310c77fcf29eb4c895cf4516dacda6

JeroMiya commented 7 years ago

Sorry if we duplicated effort on this. Note: https://github.com/sensics/OSVR-RenderManager/commit/0e2d6845e8310c77fcf29eb4c895cf4516dacda6 is not a complete solution. I have the full solution (including this change) locally, but haven't had time to fully test and pull request.