search

sensics / OSVR-RenderManager

Apache License 2.0
63 stars 45 forks source link

RM links against C++ API of OSVR Core, requiring runtime, compiler match #193

Open rpavlik opened 7 years ago

rpavlik commented 7 years ago

The logging code is currently linking against the OSVR-Core osvrUtil library's internal C++ API to get the "full" logging API. Unfortunately, this means that RM and Core must be built by the same compiler, in the same configuration, against the same runtime library.

I've stubbed out an hourglass interface to solve this problem (putting the C++ API behind a C one, then wrapping the C API with a C++ header-only API that strongly resembles the original API) here: https://github.com/OSVR/OSVR-Core/tree/c-api-for-full-logging - it just needs implementation.

cc @JeroMiya

See comments on commit https://github.com/OSVR/OSVR-Core/commit/1cd58bccab04502b45bba41a625dccf62fe6edda for status

russell-taylor commented 7 years ago

Or we could pull RM into the OSVR-Core structure, putting it under osvr/renderkit, and then compile it all at once...

rpavlik commented 7 years ago

yes, but a C API would make it less fragile anyway, and is faster to do.