search

sensics / OSVR-RenderManager

Apache License 2.0
63 stars 45 forks source link

Debug runtime capable #194

Closed rpavlik closed 7 years ago

rpavlik commented 7 years ago

Builds NDA files as object libs, instead of as a part of the main lib - only/easiest way I could see to change their compile flags. On MSVC, we remove flags that would generate debug symbols (unless you change a CMake config options), so we can generate debug builds, even with symbols, that respect the NDAs. Should verify by exploring/extracting data from PDBs built this way, but it should be OK.

rpavlik commented 7 years ago

@russell-taylor can you try building with this pull request and make sure you don't find its new way of building things not morally objectionable? :wink: It does make the various NDA modules show up as separate projects in VS.

russell-taylor commented 7 years ago

Rebased and pulled in another request because I had done another commit earlier while my network was down.

russell-taylor commented 7 years ago

Look great, by the way.

rpavlik commented 7 years ago

Great, thanks for the review. I'll update the CI then to build and ship debug versions as well. If we actually want to ship PDBs, I realized we need one more little PR like we just merged over in Core, but probably no rush on that.

This solves a high priority support ticket and should improve dev experience on Windows substantially.