search

sensics / OSVR-RenderManager

Apache License 2.0
63 stars 45 forks source link

getDisplayFrameBuffer should be GLuint not GLint #225

Closed JeroMiya closed 7 years ago

JeroMiya commented 7 years ago

The current toolkit function getDisplayFramBuffer has a GLint out argument, when it should be GLuint, because glBindFramebuffer takes a GLuint.

Technically, this is a breaking change, but it's unlikely to break existing apps in practice as the size of the argument doesn't change and it's highly unlikely the app will have more than max-int framebuffers.

russell-taylor commented 7 years ago

Fixed in 75318eabd698bf1c42f64fd5ded77587215e1eb0