search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

Simplify enable disable #263

Closed rpavlik closed 7 years ago

rpavlik commented 7 years ago

This encompasses pull requests in the NDA submodules as well as some changes in the main repo, generally to simplify and standardize handling of the list of vendor IDs that might be involved in direct mode. It is a logical continuation of an earlier pull that made the vendor ID list into a header of its own.

There are now two vendor ID lists - one contains vendor IDs we'll investigate to see if they're in direct mode, but won't automatically put in direct mode. Samsung was moved to this list, so that we don't automatically put any samsung regular monitors into direct mode, e.g. on AMD where product-specific whitelisting by the driver isn't required.

DirectModeDebugging (for NVIDIA) now also uses this list, and can take command line args - try -h.

Both the AMD and NVIDIA direct mode enter/exit apps have the same interface now since everything except the vendor-specific actual manipulation of direct mode is shared between them using a single header. (This also means that the AMD direct mode utils now handle all the vendor IDs that the NVIDIA one has been able to handle)

rpavlik commented 7 years ago

OK, I've added a --no-wait switch by factoring out and reusing the argument parsing from direct mode debugging which already had that. Will update this PR once more, when the nvidia submodule PR is merged.