search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

Read params from display config #322

Closed russell-taylor closed 6 years ago

russell-taylor commented 7 years ago

Resolves issue https://github.com/sensics/OSVR-RenderManager/issues/293

russell-taylor commented 7 years ago

Also added C API adjustment, which also fixes https://github.com/sensics/OSVR-RenderManager/pull/322

rpavlik commented 7 years ago

Why are we having the config specify near and far? That's an app concern... some do inverted or infinite z, for instance...

russell-taylor commented 7 years ago

These were added there to have a place to specify the defaults, along with IPD. All of these can be overridden by the application on a per-frame basis. They have default values if they are not specified so don't require adding them to the config file. If it seems better to remove them and place their defaults back in the object constructor, that would be okay but less flexible.

russell-taylor commented 7 years ago

Reverted the C API changes, so should be ready to merge.

russell-taylor commented 6 years ago

What is the continued hold on accepting this pull request?