search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

Just in timewarp #330

Closed russell-taylor closed 6 years ago

russell-taylor commented 6 years ago

This implements a new just-in-timewarp function that addresses within-frame distortion using shear and anisotropic scaling to remove the effects of perceived object distortion on a line-by-line basis.

This also incorporates the changes in an earlier (now removed) pull request that provides timing information in D3D Extended mode (which was very helpful in debugging, and which is required to enable just-in-timewarp in extended mode).

This pull request depends on one already made in OSVR-Core. It would be great if this could be out before the VR Gems book chapter describing it goes to the publisher next week...

russell-taylor commented 6 years ago

Love to see the pull request on OSVR-Core and this one accepted so I can update the book chapter text and re-send to the editor. Thanks!

JeroMiya commented 6 years ago

This looks good to me. If @rpavlik doesn't have any objections tomorrow morning, I'll go ahead and thumbs-up this so you can merge.

ChristophHaag commented 6 years ago

Has anyone tested compiling on linux after this pull request?

/home/chris/oldhome/build/osvr-rendermanager/src/osvr-rendermanager/osvr/RenderKit/RenderManagerBase.cpp: In member function 'virtual bool osvr::renderkit::RenderManager::ComputeAsynchronousTimeWarps(std::vector<osvr::renderkit::RenderInfo>, std::vector<osvr::renderkit::RenderInfo>, float)':
/home/chris/oldhome/build/osvr-rendermanager/src/osvr-rendermanager/osvr/RenderKit/RenderManagerBase.cpp:1623:26: error: 'RenderManagerD3D11Base' does not name a type; did you mean 'RenderManager'?
         if (dynamic_cast<RenderManagerD3D11Base*>(this)) {
                          ^~~~~~~~~~~~~~~~~~~~~~
russell-taylor commented 6 years ago

Whoops. I'll take a look at it now.

russell-taylor commented 6 years ago

Fixed in pull request https://github.com/sensics/OSVR-RenderManager/pull/336

Sorry about that, and thanks for pointing it out.

russell-taylor commented 6 years ago

Kevin beat me to the fix with a better solution. Pulled into master.