search

sensics / OSVR-RenderManager

Apache License 2.0
64 stars 45 forks source link

OpenGL Optimization work #363

Closed JeroMiya closed 6 years ago

JeroMiya commented 6 years ago

Note: due to the number of changes in this PR, I'm going to do a clang-format in a separate PR so it doesn't make a bunch of diffs.

JeroMiya commented 6 years ago

OK @russell-taylor I think I addressed all of your questions/comments. Could you take a second look? Thanks!

JeroMiya commented 6 years ago

OK @russell-taylor I cleaned up the RenderManagerOpenGL destructor and separated out the loops so that there is one for each std::vector rather than reusing a loop for one and assuming they're the same size. Your other added comment was for a change that I had already reverted.

russell-taylor commented 6 years ago

Sounds good. I'm assuming that you have tested it on various OS/graphics configurations; I have not.