search

sensiolabs / BehatPageObjectExtension

MIT License
116 stars 48 forks source link

Added php7.4 #128

Closed DonCallisto closed 4 years ago

DonCallisto commented 5 years ago

With php7.4 behind the corner, I tought it was good to try this against new version.

DonCallisto commented 5 years ago

It seems we'll need to wait for that https://github.com/phpspec/phpspec/pull/1269 to be merged. Do you prefer to keep this PR open or ... ? Moreover we can also bump PHPSpec version to 6 (I've seen it won't add nothing useful for us, in case you agree I can open a different PR)

jakzal commented 5 years ago

Thanks for this! Such a shame we didn't manage to meet on SymfonyCon. I could've shown you the idea for new page-object library :(

jakzal commented 5 years ago

Also, would you mind to send this PR against the 2.3 branch?

DonCallisto commented 5 years ago

Thanks for this! Such a shame we didn't manage to meet on SymfonyCon. I could've shown you the idea for new page-object library :(

Yeah, what a pity! Talk about this project in front of a beer would have been great. Maybe we'll get the chance at SymfonyCon2020 or if you apply for PHPDay Italy (I think the CFP is open). BTW if you want to share some thoughs we can managed this online with slack or whatever.

Gonna change the base of PR ;)

DonCallisto commented 5 years ago

Done! :)

jakzal commented 5 years ago

Seems that there's no phpspec version that supports PHP 7.4 yet :(

DonCallisto commented 5 years ago

https://github.com/phpspec/phpspec/pull/1269

DonCallisto commented 5 years ago

https://github.com/phpspec/phpspec/releases/tag/6.1.0

I think I can also bump PHPSpec version now on go on with this. WDYT?

jakzal commented 5 years ago

Go for it. You'll probably need to drop PHP 7.1, which is fine.

DonCallisto commented 5 years ago

We're still in a showstopper situation, take a look --> https://github.com/BossaConsulting/phpspec2-expect/pull/59

DonCallisto commented 5 years ago

Nevermind, they merged the PR. Let's check if CI is green.

Edit: Still no new tagged version yet :\

DonCallisto commented 5 years ago

WoW, huge of trouble with this version bumping :smile: Take a look at this https://github.com/FriendsOfPHP/Goutte/issues/393

I know is related to --prefer-lowest composer flag but...

DonCallisto commented 5 years ago

Ok I've done also some other fixes (https://github.com/sensiolabs/BehatPageObjectExtension/pull/128/commits/48f1fbcac25729e5a0a4024da31a59ed91d5a4cb), now if on Goutte they raise Guzzle version we should be fine otherwise what would you do? I won't like the idea to drop --prefer-lowest check actually.

jakzal commented 4 years ago

What if we added a conflict with older versions of guzzle?

DonCallisto commented 4 years ago

How? Don’t understand the question.

jakzal commented 4 years ago

I'm talking about adding guzzle to the conflict section of composer.json. Not sure if it impacts --prefer-lowest though.

DonCallisto commented 4 years ago

Umh, don't know if that's gonna work but how about require Guzzle directly in our lib with the right version? I know it's not a direct dependency but we can mitigate the problem unless a more restrictive version of Goutte will be released. I really don't like this solution but I think would work.

jakzal commented 4 years ago

Yeah, one of the two should work :)

DonCallisto commented 4 years ago

conflict works like a charm. Didn't knew about it, thanks for sharing this. BTW please check if I've introduced too strict version (I think I've not but let's double check)

jakzal commented 4 years ago

Thank you so much for working on this! 🍻