Closed RebOOter closed 7 years ago
You can still override the verify()
function to implement custom logic (or no logic). Currently people rely on the behaviour of open()
and changing it would break their test suites (the least it will relax some checks).
I don't think that it's good solution, but if other people rely on it that will be problem to change it.
In
open()
function you haveverify()
function that check opened URL with current but this is wrong solution. For example: you have http://example.com/url1 that redirect you to http://example.com/url2. You want to check this redirection but with this implementation ofopen()
function this wouldn't work.All checkers and asserts shouldn't be in action function.
I suggest to remove this from
open()
function.