search

sensiolabs / BehatPageObjectExtension

MIT License
117 stars 48 forks source link

Remove path and selector from page and element #97

Closed DonCallisto closed 6 years ago

DonCallisto commented 6 years ago

Hi @jakzal, why are we using a protected property? Shouldn't be better to declare this an abstract method (as well as selector for elements)?

If this could be an improvement, we can include this for a next major release and introduce a deprecation message to the current one.

What do you think?

jakzal commented 6 years ago

As I said in https://github.com/sensiolabs/BehatPageObjectExtension/pull/99#issuecomment-334140611 I don't even remember why this is protected. Perhaps I thought people will find it useful to override it, but I didn't want to force them to implement the method as it's actually not required, unless you call open() on a page (not every page is opened directly, in most cases they're returned as a result of method calls on other pages).

Anyway, In the referenced ticket I gave some ideas on how we could improve the current state. I'd appreciate your input.

DonCallisto commented 6 years ago

Ok, let's continue in #99