sensorflo / adoc-mode

A major-mode for editing AsciiDoc files in Emacs
https://github.com/sensorflo/adoc-mode/wiki
76 stars 41 forks source link

Promote and demote #22

Open danielmatz opened 8 years ago

danielmatz commented 8 years ago

I'm a little confused by your word choice for adoc-promote and adoc-denote.

First, the opposite of promote is demote, not denote. Denote means to indicate.

Second, promote in this sense means to increase in rank. Shouldn't that take a heading and make it a more important heading? Right now, it turns a heading into a subheading.

Minor issues, I know, but I thought I'd open an issue anyway. Thanks for adoc-mode!

sensorflo commented 8 years ago

You're right in both points. I corrected the mistake of saying denote of demote and pushed the commit. I am not sure if I now should toggle the meaning of demote and promote, now that the 'wrong' meaning is already out for a few years.

nicorikken commented 8 years ago

Had this same remark starting to use adoc-mode. The current inverse behavior is just confusing to me.

jack99999 commented 6 years ago

just found the promote/demote key bindings. definitely backwards.

incidentally, the wiki home page has two occurrences of 'denote' instead of 'demote'