search

sensorium / Mozzi

sound synthesis library for Arduino
https://sensorium.github.io/Mozzi/
GNU Lesser General Public License v2.1
1.06k stars 185 forks source link

Compile and runtime error when EXTERNAL_AUDIO_OUTPUT is true #173

Closed pschatzmann closed 1 year ago

pschatzmann commented 1 year ago

On an ESP32, when setting the EXTERNAL_AUDIO_OUTPUT to true I was running into compile errors. After correcting them, I was running into runtime errors in my tests because the divider of 1 is not allowed. After this correction the functionality is working again.

In my tests I was measuring a sample rate of 32753...

tomcombriat commented 1 year ago

Hi, Unfortunately I do not have the hardware to test this, hopefully someone else does around. Otherwise looks good!

pschatzmann commented 1 year ago

I think it is pretty much low risk, because there is hardly any need for this, nobody is using it. The output to I2S, the Internal DAC and PDM is basically all one needs.

I just thought that it gives a bad picture to run into compile errors.

I tried to use this functionality, but it does not really fit into the audio architecture of the ESP32. I could just think of using this to output audio via PWM.

tomcombriat commented 1 year ago

Alright, will merge very soon if the others have no objections. Thanks!