sensorium / Mozzi

sound synthesis library for Arduino
https://sensorium.github.io/Mozzi/
GNU Lesser General Public License v2.1
1.09k stars 187 forks source link

New examples #272

Closed tomcombriat closed 2 months ago

tomcombriat commented 3 months ago

Adding two new examples:

Still work in progress, the former does not sound synthy enough to my taste, and the later is very basic.

tomcombriat commented 3 months ago

(Report jobs are failing because no previous versions of these examples were found to compare the memory, kinda ironic!)

tomcombriat commented 3 months ago

Start to sound good! Here are some demo sounds (recording straight from an UNO R3):

Filter_envelope:

https://github.com/user-attachments/assets/90759e9f-8ebc-43ac-8561-a1bba82b5115

RingModulator

https://github.com/user-attachments/assets/530d9e54-2b3f-44af-bf25-02b0d9ebed22

The Filter envelope does not show in my list of Arduino examples, I do not understand why. The RM does work well, if someone has an idea...

sensorium commented 2 months ago

Hi Tom, looking and sounding good. Did you get the Filter showing up in examples yet? I don't see any obvious clues... Are you happy to merge, @tfry-git ?

sensorium commented 2 months ago

It would be good to add them to the examples page on the site, too.

tomcombriat commented 2 months ago

It would be good to add them to the examples page on the site, too.

Yes indeed, I will try to do that!

tomcombriat commented 2 months ago

Good eye as always @tfry-git! Will correct soon, thanks!

tomcombriat commented 2 months ago

Ok, I implemented the changes. I also renamed the RingModulator example, as, actually, this is not really a RM, but more a self modulator. The two examples shows in the IDE (cause was an hidden file locally).

@sensorium For the website, I have to say I do not have a very clear view how all that is done… Are you using the scripts in extras/devscripts to automate the process of having all the examples copied to the gh-pages and generate the audio samples?

sensorium commented 2 months ago

Hi Tom,

yes, I was using those scripts when Mozzi was developing, to check that all the examples worked locally after code changes and keep the pages in sync. But with the checks you and Thomas have set up on Github and the more orderly development process, the scripts don't seem necessary anymore (I wonder whether to remove them to save confusion?). I'd suggest to just edit the markdown for the webpage directly - what do you think?

tomcombriat commented 2 months ago

Yes probably! I was just wondering about all the examples which are in the website (not the doxygen), that these pages seemed somehow to be generated automatically. Is this in the gh-page workflow or should I add them to this page manually?

sensorium commented 2 months ago

I haven't made any Github workflows, if that's what you mean. Any automation was local just with those scripts. Don't go there! You probably noticed the duplication of all the example sketches with their recordings. I expect it's out of date and missing a few sketches - maybe I can regenerate it locally, if it looks like too much to update manually. I'd have to set up a few things including hardware for recording, so I'm kind of hoping gradual changes by hand will be OK, but let me know.

tomcombriat commented 2 months ago

Merging. Will add the needed doc soon in another PR!

tomcombriat commented 2 months ago

Just to confirm, the changes made to example-list.markdown for example: https://github.com/sensorium/Mozzi/commit/d8e44a669cd4da136ddcd205d539f874e950ae3f were all done manually recently, or I guess the script extras/devscripts/mozzi_generate_examples_page_buttons.sh can be of good use?

I'll try to use that to regenerate the page, looks like there is nothing depending on the local architecture of the files in this one (which is not the case of extras/devscripts/mozzi_generate_page.sh)

tfry-git commented 2 months ago

Yes, I have used an existing script (and probably it was extras/devscripts/mozzi_generate_examples_page_buttons.sh) for updating the examples page.

tomcombriat commented 2 months ago

Thanks!