Install package is missing a 'vendor' folder

[twelvetrains]

After installing the whmcs-moneybird module the following error occurs in WHMCS:

— Fatal error: require(): Failed opening required '/home/twelve1q/public_html/accounts/modules/addons/moneybird/vendor/autoload.php' (include_path='.:/opt/alt/php73/usr/share/pear') in /home/twelve1q/public_html/accounts/modules/addons/moneybird/moneybird.php on line 22 —

Composer version 1.8.4 is running on the server.

When checking the installation files there is no 'vendor' folder. Am I missing something? And with composer version should be used with this module?

Thanks.

[ju5t]

The module has no preference when it comes to Composer but personally I would suggest moving onto version 2 as it's the latest stable version out there. Note that Composer is a dependency manager for PHP, you need to run it inside the module's folder to get a vendor folder.

Can you perhaps give a bit more detail what you have done? What steps have you taken so far that got you to this point? Did you use the version from Github or did you use the pre-packaged version (which I just found does not include the vendor folder as it should, so this needs be fixed, see #21).

In #14 you had the same issue. Could you explain what changed in the meantime?

[twelvetrains]

Hi, and thanks for your reply. In the installation instructions Composer is mentioned as required:

https://github.com/sensson/whmcs-moneybird

See the instructions further below.

I used downloaded the package from Github. When the correct /vendor/ and files has been added to Githhub I assume that it will work.

[twelvetrains]

Regarding your question "In #14 you had the same issue":

That was with a previous version of WHMCS and of the Moneybird module. And to be honest, I had forgotten about that. But I now see my own suggestion for a better and more clear instruction in that thread, which works for cPanel:

https://github.com/sensson/whmcs-moneybird/issues/14#issuecomment-581910686

I have now followed my own instructions and that worked!

What a pity that you haven't updated the instructions to include my suggestion. That would have saved both me and you time and especially me a couple of hours of frustration. :-(

But thanks for reminding me about the same issue back then.

[twelvetrains]

It did work, except the 'Workflow Mapping' button in the Moneybird settings which gives an error. See screenshot:

https://www.dropbox.com/s/ltbny8hheuquq6i/workflow_mapping%20error.png?dl=0

[ju5t]

That was with a previous version of WHMCS and of the Moneybird module.

You don't have to reinstall the Moneybird module when you're updating WHMCS. It should just work.

What a pity that you haven't updated the instructions to include my suggestion. That would have saved both me and you time and especially me a couple of hours of frustration. :-(

If you feel the README is incomplete or could be improved, feel free to PR these changes.

We open source our projects for two reasons. First and foremost it's about sharing knowledge, it's about helping others and saving some time. The second reason is about the community. Instead of building features or changing options ourselves, open sourcing this code allows others to improve it too, through PR's.

Open source also provides open communication. It gives users of our software the possibility to search in previous issues, which we're a huge fan of (as a user of other open source software)!

About the vendor folder not being included; this is primarily a git-thing. Including the vendor folder has a lot of downsides and it's very uncommon to have it inside the git repository. This is why we tried to build a solution that includes the vendor-folder, but this didn't work, so this needs some effort.

It did work, except the 'Workflow Mapping' button in the Moneybird settings which gives an error. See screenshot:

Hm, I'm not sure what happens there. Which version of WHMCS are you using right now? Does this happen when you submit a form or when you just view the workflow mapping page? Can you also share if you have enabled some payment gateways as from what you said this seems a new WHMCS installation?

It could be that WHMCS changed something internally.

[twelvetrains]

I really appreciate that this is an open source project. Though I did assume that Moneybird is supporting the project financially, but maybe that is not so? I've now created a fork with a change suggestion to the README.md file. :)

The automatic update messed up my WHMCS installation so I had to update manually. This has happend before and it's always a hassle to get everything working again, as with the Moneybird module. I had to upload and reconfigure several modules I use again.

Hm, I'm not sure what happens there. Which version of WHMCS are you using right now? Does this happen when you submit a form or when you just view the workflow mapping page? Can you also share if you have enabled some payment gateways as from what you said this seems a new WHMCS installation?

I installed the latest stable version 8.3.2 of WHMCS. It happens when I want to view the workflow mapping page, so just when clicking the workflow mapping link. I have enabled the same payment gateways as before the update: Cash and a few Mollie payment options.

Thanks for your time, I appreciate it!

[ju5t]

Moneybird is not supporting this in any shape or form. In fact, because it's an open source project without a formal support structure, they didn't want to include it in their documentation, where other paid solutions are advertised. In a way you could say it's paid for by Sensson, although we just share what we use ourselves.

ps. in your fork, you need to open a PR (Pull Request). I think it points you to that automatically? If not, about pull requests is probably a good starting point.

I installed the latest stable version 8.3.2 of WHMCS. It happens when I want to view the workflow mapping page, so just when clicking the workflow mapping link. I have enabled the same payment gateways as before the update: Cash and a few Mollie payment options.

Ok, not yet sure what causes this yet but it helps. I will try to spend some time on it tomorrow to see if I can pin point the problem. We're a few versions behind so it might be something has changed. Are all other pages working fine? E.g. the ledgers? And is it loading all Moneybird data there as you'd expect?

[twelvetrains]

Sorry for my late reply. Quite an odd choice of Moneybird.

I created a pull request which you must now be able accept or deny.

The importing of the invoices is working, so that does now work as expected. Yes, all other pages like the legers are working fine. So for me we can leave it as is for now.

Thanks again for your time!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We get that this might not be what you had expected but we're trying to limit stale as issues as much as possible. Thank you for your contributions.