sensu-plugins / sensu-plugin

A framework for writing Sensu plugins & handlers with Ruby.
http://sensuapp.org
MIT License
126 stars 117 forks source link

[WIP] Use sensu-json instead of json gem #133

Closed amdprophet closed 8 years ago

amdprophet commented 8 years ago

This PR replaces the json gem with the sensu-json gem as per #127. There are some limitations that should be considered before this PR should be considered a candidate for merging:

Advantages:

Disadvantages:

I'm not currently in favour of having this merged as-is. I think we need to ensure keys can be accessed via both strings & symbols. I don't have much of an opinion regarding Oj & C bindings as many Sensu plugins already have gem dependencies with C bindings.

Any feedback, criticism, or corrections will all be greatly appreciated!

amdprophet commented 8 years ago

After thinking about this a bit more and discussing it with @portertech, I'm going to close this PR. I'll investigate using stdlib json and multi-json as alternatives.