sensu-plugins / sensu-plugin

A framework for writing Sensu plugins & handlers with Ruby.
http://sensuapp.org
MIT License
126 stars 117 forks source link

This plugin is not consistent with many of the practices followed by most plugins #175

Open majormoses opened 7 years ago

majormoses commented 7 years ago

I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:

I am sure there are plenty others...

portertech commented 7 years ago

These all seem like reasonable suggestions. It is important to remember that this library is not a plugin, but the very backbone of every Sensu community plugin, and its practices may differ due to its very nature.

majormoses commented 7 years ago

Agreed that it is different and does not need to be in 100% alignment but none of these things that were brought up seem plugin specific.

majormoses commented 7 years ago

only one I see that might be different would be added rake tasks and a possibly modified rubocop config.

luisdavim commented 7 years ago

Hi, I've just opened #177 that addresses the rubocop part, the configuration I've added is not exactly the same as the one in the skel plugin but it's a start.