Open majormoses opened 7 years ago
These all seem like reasonable suggestions. It is important to remember that this library is not a plugin, but the very backbone of every Sensu community plugin, and its practices may differ due to its very nature.
Agreed that it is different and does not need to be in 100% alignment but none of these things that were brought up seem plugin specific.
only one I see that might be different would be added rake tasks and a possibly modified rubocop config.
Hi, I've just opened #177 that addresses the rubocop part, the configuration I've added is not exactly the same as the one in the skel plugin but it's a start.
I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:
v$VERSION
. Anyways not trying to start a religious war here, just pointing out areas in where there are differences and we should standardize where possible. As this is the outlier in 180+ plugins I vote we make the change here and not force a lot of extra work on converting everything over.I am sure there are plenty others...