sensu-plugins / sensu-plugin

A framework for writing Sensu plugins & handlers with Ruby.
http://sensuapp.org
MIT License
126 stars 117 forks source link

update lock for `mixlib-cli` to `~> 1.5` as 2.0 removes ruby < 2.5 support #198

Closed majormoses closed 5 years ago

majormoses commented 5 years ago

Description

Fixes an issue reported: https://sensucommunity.slack.com/archives/C3C1D874M/p1546782233015800 due to mixlib-cli version 2.0 dropping support for ruby < 2.5

Error this fixes:

...
[SENSU-INSTALL] installing Sensu gem 'sensu-plugins-cpu-checks'
ERROR:  Error installing sensu-plugins-cpu-checks:
       mixlib-cli requires Ruby version >= 2.5.
[SENSU-INSTALL] failed to install Sensu gem 'sensu-plugins-cpu-checks'
...

Motivation and Context

see above

How Has This Been Tested?

beyond existing automated tested I have not done anything special for it.

Types of changes

Checklist:

Known Caveats

none, technically this affects multiple versions but its unlikely worth backporting the fix more than each major version.

majormoses commented 5 years ago

It looks like the failures for ruby 2.1 are caused by having super old bundler and ruby installed and it gets uninstalled and reinstalled improperly. Due to the high impact of this bug I am gonna merge and release it. I have created #199 to address the CI issues with ancient rubies.

majormoses commented 5 years ago

released: