search

sensu-plugins / sensu-plugins-aws

This plugin provides native AWS instrumentation for monitoring and metrics collection, including: health and metrics for various AWS services, such as EC2, RDS, ELB, and more, as well as handlers for EC2, SES, and SNS.
http://sensu-plugins.io
MIT License
81 stars 143 forks source link

Trusted Advisor Service Limits check ID eW7HH0l7J9 deprecated. #374

Closed swibowo closed 4 years ago

swibowo commented 4 years ago

Updated the script to go through Service Limits checks and look for status not 'ok'

Pull Request Checklist

General

New Plugins

Purpose

Hello,

This notification details recent changes in the AWS Trusted Advisor Checks.

If you get AWS Trusted Advisor check data for the combined "Service Limits" check with Check ID "eW7HH0l7J9" via API [1] or CLI [2] or console [3], this notification is to inform you of three changes. You may be doing this if you:

  • Specifically call DescribeTrustedAdvisorCheckResult or DescribeTrustedAdvisorCheckSummaries for Check ID "eW7HH0l7J9"
  • Get a list of all checks in Trusted Advisor by calling DescribeTrustedAdvisorChecks and then get check result data or check summary data for each of the checks in the list by calling DescribeTrustedAdvisorCheckResult or DescribeTrustedAdvisorCheckSummaries.
  • Use the console (UI) to download the Excel sheet with all check results in it. What is changing?

There are three changes, outlined below:

  • We have now enabled the newly launched vCPU-limits [4] with the EC2 On Demand Instances Service Limit check (ID: "0Xc6LMYG8P").
  • The combined "Service Limits" check with check ID "eW7HH0l7J9" no longer includes EC2 service limit information.
  • We plan to disable the combined "Service Limits" check with check ID "eW7HH0l7J9" on February 15, 2020. After this time you will not be able to access this check via API, CLI or console.

How do I mitigate for this change?

  • We recommend discontinuing the use of the Service Limits check (check ID "eW7HH0l7J9"). Instead, we recommend obtaining service limit data from the separate checks, per service, in the "service limit category" [5]. The checks in "service limit" category include all the information in the combined Service Limits check as well as 11 additional checks for improved coverage.
  • For EC2 service limits specifically, we recommend using the EC2 On Demand Instances Service Limit check (ID: "0Xc6LMYG8P") which now has support for vCPU limits.
  • If you use the console (UI) to download the Excel sheet with all check results in it, you will still be able to view service limits shown in individual tabs for each service. The EC2 service limits information is available in the tab named "EC2 On-Demand instances".

Known Compatibility Issues

swibowo commented 4 years ago

@majormoses - could you please have a look at the travis env? Looks like bundler have changed since the last successful build?

majormoses commented 4 years ago

@swibowo I took a look and made some updates, my guess is that they starting installing a newer version of bundler in the travis image. I committed to your branch some changes which I believe will fix travis builds.

majormoses commented 4 years ago

released: https://rubygems.org/gems/sensu-plugins-aws/versions/18.5.0