search

sensu-plugins / sensu-plugins-aws

This plugin provides native AWS instrumentation for monitoring and metrics collection, including: health and metrics for various AWS services, such as EC2, RDS, ELB, and more, as well as handlers for EC2, SES, and SNS.
http://sensu-plugins.io
MIT License
81 stars 143 forks source link

Bonsai asset deployment failing #385

Open jsnod opened 3 years ago

jsnod commented 3 years ago

Per discussion in https://github.com/sensu-plugins/sensu-plugins-aws/pull/348#issuecomment-748476466, it appears that the Bonsai asset deploy is silently failing: https://travis-ci.org/github/sensu-plugins/sensu-plugins-aws/jobs/643238482#L5268

That means that Bonsai is stuck at v18.4.0, so users are unable to install v18.5.0 via sensuctl asset add sensu-plugins/sensu-plugins-aws

There are some fixes in v18.5.0 that I need in a brand new Sensu Go install, so it would be great to get the latest version pushed up to Bonsai.

/cc @majormoses @jspaleta

nixwiz commented 3 years ago

Are we sure it silently failed? It created the 18.5.0 release. However, when asking Bonsai to recompile releases, it fails because the .bonsai.yml and the release assets actually created do not line up. I had already submitted a fix to .bonsai.yml that has not been released.

nixwiz commented 3 years ago

@majormoses this should be fixed if we merge #386 , cut a new release and then have Bonsai recompile releases.

majormoses commented 3 years ago

@nixwiz thanks for the PR I will get that this evening if possible.

majormoses commented 3 years ago

I have cut a release and am waiting for travis to publish the artifacts.

majormoses commented 3 years ago

https://github.com/sensu-plugins/sensu-plugins-aws/releases/tag/18.6.0

majormoses commented 3 years ago

I am not sure this is fixed, I see the ruby gem published but looks like its failing to compile for bonsai asset.

image

majormoses commented 3 years ago

I see a couple errors in the travis output:

jsnod commented 3 years ago

@nixwiz @majormoses Any update here? Is it safe to install v18.6.0 if Bonsai is complaining about compilation errors?

jsnod commented 3 years ago

Answered my own question, 18.5.0 and 18.6.0 will not install. 18.4.0 does:

> sensuctl asset add sensu-plugins/sensu-plugins-aws -r sensu-plugins-aws
no version specified, using latest: 18.6.0
fetching bonsai asset: sensu-plugins/sensu-plugins-aws:18.6.0
Error: error putting resource #0 with name "sensu-plugins-aws" and namespace "default" (/api/core/v2/namespaces/default/assets/sensu-plugins-aws): resource is invalid: SHA-512 checksum cannot be empty

> sensuctl asset add sensu-plugins/sensu-plugins-aws:18.5.0 -r sensu-plugins-aws
fetching bonsai asset: sensu-plugins/sensu-plugins-aws:18.5.0
Error: error putting resource #0 with name "sensu-plugins-aws" and namespace "default" (/api/core/v2/namespaces/default/assets/sensu-plugins-aws): resource is invalid: SHA-512 checksum cannot be empty

> sensuctl asset add sensu-plugins/sensu-plugins-aws:18.4.0 -r sensu-plugins-aws
fetching bonsai asset: sensu-plugins/sensu-plugins-aws:18.4.0
added asset: sensu-plugins/sensu-plugins-aws:18.4.0

You have successfully added the Sensu asset resource, but the asset will not get downloaded until
it's invoked by another Sensu resource (ex. check). To add this runtime asset to the appropriate
resource, populate the "runtime_assets" field with ["sensu-plugins-aws"].
edgan commented 3 years ago

This is still broken. Any word?

edgan commented 3 years ago

@jsnod I got them to fix 18.5.0 two days ago. 18.6.0 is still broken as of now.