sensu-plugins / sensu-plugins-chef

This plugin provides native instrumentation for monitoring Chef, including service health checks (via chef-server-ctl) and chef node status, and a Sensu handler for removing stale Sensu clients.
http://sensu-plugins.io
MIT License
6 stars 16 forks source link

Decommission handler #11

Closed psyhomb closed 7 years ago

psyhomb commented 8 years ago

I've modified handler-chef-node.rb handler a bit and I've added some additional functionalities like Flapjack support and possibility to disable chef check and to trigger a handler only if keepalive occurrences value reach a certain threshold (handled through Sensu filter feature). Also in order to suppress some ridley WARN messages (e.g. WARN -- : Terminating task: type=:finalizer, meta={:method_name=>:shutdown}, status=:receiving) a logger severity level has been set to ERROR.

Cheers

mattyjones commented 8 years ago

@psyhomb

Can you please add some tests for this as well as update the CHANGELOG please.

psyhomb commented 8 years ago

@mattyjones

Can you please be a little bit more specific about tests?

Anyhow I'm using this handler in the production for quite some time and everything is running smoothly and without any issues.

I have updated the CHANGELOG as well

Cheers

majormoses commented 7 years ago

closing due to inactivity, please reply back if you intend to see this through to completion and we can re-open.