Closed hartmantis closed 6 years ago
Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.
The latest refactor splits out all the shared logic for these two new checks into a "base" library. I believe it covers all the previous comments, but let me know if I missed something. Thanks!
Pull Request Checklist
Is this in reference to an existing issue?
It is not.
General
[x] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
[x] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass
New Plugins
[x] Tests
[x] Add the plugin to the README
[x] Does it have a complete header as outlined here
Live tests (done on a cluster with five live servers, one failed server, and one stale peer):
Purpose
We recently had to go through a Consul outage recovery on a cluster that, it turned out, had been slowly accumulating stale peers in its raft configuration until it no longer had enough for quorum and died.
The
check-consul-stale-peers
check would examine the raft config for peers that have gone stale ("(unknown)") while thecheck-consul-quorum
check would monitor how many servers a cluster can lose while still maintaining quorum.Known Compatibility Issues
N/A