Enable Bonsai Asset Build

sensu-plugins / sensu-plugins-consul

This plugin provides native instrumentation for monitoring Consul, including: Consul server service and cluster health, and querying the Consul API to check for passing/critical services.

http://sensu-plugins.io

MIT License

13 stars 25 forks source link

Enable Bonsai Asset Build #62

Closed terraboops closed 3 years ago

terraboops commented 5 years ago

Pull Request Checklist

Adding Bonzai the same way it was done for this PR: https://github.com/sensu-plugins/sensu-plugins-network-checks/pull/94

General

[x] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

Purpose

Enable Sensu Go Asset building
Remove unsupported ruby assets

Known Compatibility Issues

terraboops commented 5 years ago

Sorry I don't know if Binstubs are needed...

Let me know if there's anything else you'd like me to change to get this merged. Thanks.

terraboops commented 5 years ago

Ping!

I think this is a useful PR... I am using a fork of it from here and it's working well: https://github.com/tylermauthe/sensu-plugins-consul/releases/tag/3.0.0

Anything else I can do to help get this merged @majormoses? 🙇

nixwiz commented 4 years ago

@tylermauthe could you take a look at the .bonsai.yaml file in #64 and update this PR to include it? It has more build targets and it makes use of platform_family to provide better filtering.

terraboops commented 4 years ago

@nixwiz - when I added that, the build broke https://travis-ci.org/sensu-plugins/sensu-plugins-consul/builds/642666307

However, I have reverted my changes to the original and it seems the build is still broken. Is master building correctly? Has a new test been added?

Note: I haven't even looked at the error output - but I do notice that all recent builds on PRs are failing.

majormoses commented 4 years ago

the failure is the version of bundler being installed in travis differs from what is specified in the gemspec:

We probably want to specify in the travis file to install/upgrade (a specific version) of bundler before attempting to bundle for example: https://github.com/sensu-plugins/sensu-plugins-windows/blob/83a67bf66a33c7b6762c3a7335284501aff1c1bb/.travis.yml#L5.