Closed envintus closed 7 years ago
Done! Thanks for the quick response.
If you're someone to talk to about contributing to these repositories then I'd like to chat with you should you have time. My email is hsatterwhite@envintus.com.
[image: FC_MIC2017StandardLogo.png]
[image: TransLoc_logos_wordmark_blue.png]
Hunter Satterwhite
Lead Build & Operations Engineer, TransLoc
252.762.5177 | www.transloc.com
[image: facebook-color-32px.png] https://www.facebook.com/TransLoc/ [image: linkedin-color-32px.png] https://www.linkedin.com/company/transloc [image: twitter-color-32px.png] http://www.twitter.com/transloc [image: instagram-color-32px.png] http://www.instagram.com/transloc_inc
On Tue, May 2, 2017 at 12:44 PM, Ben Abrams notifications@github.com wrote:
@majormoses commented on this pull request.
In CHANGELOG.md https://github.com/sensu-plugins/sensu-plugins-cpu-checks/pull/24#discussion_r114366059 :
@@ -5,6 +5,10 @@ This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachang
[Unreleased]
+## 2017-05-02
can you remove this line?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sensu-plugins/sensu-plugins-cpu-checks/pull/24#pullrequestreview-35825911, or mute the thread https://github.com/notifications/unsubscribe-auth/AIESgixZNFVw_NV-klkM-M49pfUtGitdks5r1115gaJpZM4NOOXm .
@envintus thanks after tests pass I can merge this and will try to cut releases tonight on a bunch of sensu plugins, there is a lot of unreleased changes currently. I am trying to spend a bit of time doing some sweeping passes accross the repos but it just takes a bit of time.
@envintus I have reached out to you privately on the process for becoming a maintainer.
Pull Request Checklist
23
General
[X] Update Changelog following the conventions laid out on Keep A Changelog
[N/A] Update README with any necessary configuration snippets
[N/A] Binstubs are created if needed
[x] RuboCop passes
[N/A] Existing tests pass
New Plugins
[N/A] Tests
[N/A] Add the plugin to the README
[N/A] Does it have a complete header as outlined here
Purpose
Known Compatablity Issues
None