search

sensu-plugins / sensu-plugins-disk-checks

This plugin provides native disk instrumentation for monitoring and metrics collection, including: health, usage, and various metrics.
http://sensu-plugins.io
MIT License
27 stars 63 forks source link

Feature/major cleanup #109

Closed majormoses closed 3 years ago

majormoses commented 5 years ago

Pull Request Checklist

fixes #108, #107, #104, #98

General

Purpose

Housekeeping

Known Compatibility Issues

Drops ruby < 2.3 support and sensu-plugin library bump they are both called out in the changelog.

majormoses commented 3 years ago

Well this sat for a while...I have rebased.

jaredledvina commented 3 years ago 
bin/check-smart.rb:174:32: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Style/NumericPredicate.
317    unless @devices.length > 0 # rubocop: disable Style/NumericPredicate
318                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
319bin/check-smart.rb:184:35: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Style/NumericPredicate.
320    if unhealthy_disks.length > 0 # rubocop: disable Style/NumericPredicate
321                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
322bin/check-smart.rb:190:33: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Style/NumericPredicate.
323    if unknown_disks.length > 0 # rubocop: disable Style/NumericPredicate
324                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Looks like there's some more rubocop battles here @majormoses :/

majormoses commented 3 years ago

I went on a dependency merging spree yesterday and rubocop was one of them. This has been rebased and quite a few changes were also present in the PR had already been merged into master. As such the delta has shrunk considerably. I also did not run tests locally after rebasing as thats CIs job :wink:

jaredledvina commented 3 years ago

👍 Change looks good to me!