sensu-plugins / sensu-plugins-dns

This plugin provides native DNS instrumentation for monitoring, including: record resolution
http://sensu-plugins.io
MIT License
5 stars 26 forks source link

Expose DNS query timeout as check parameter #13

Closed winks closed 7 years ago

winks commented 8 years ago

Pull Request Checklist

Is this in reference to an existing issue?

No

General

bin/check-dns.rb:121:3: C: Assignment Branch Condition size for run is too high. [100.2/100]

Feel free to mangle the code so that the functionality fits the check

Are there any?

Purpose

Add timeout to the resolver lookup

sstarcher commented 8 years ago

failing CI and has merge conflicts

winks commented 8 years ago

I wrote why it failed the CI, because apparently Rubocop insists on extracting all CLI argument sanity checks to extra methods.

And there was no merge conflict before that PR was merged today.

winks commented 8 years ago

Updated.

majormoses commented 7 years ago

@winks could you rebase please?

winks commented 7 years ago

@majormoses Done.