Fix gsub on nil environment_tag

sensu-plugins / sensu-plugins-docker

This plugin provides native Docker instrumentation for monitoring and metrics collection, including: container status, container number, and container metrics via `docker ps`.

http://sensu-plugins.io

MIT License

35 stars 57 forks source link

Fix gsub on nil environment_tag #61

Closed epierotto closed 6 years ago

epierotto commented 6 years ago

Pull Request Checklist

Is this in reference to an existing issue? https://github.com/sensu-plugins/sensu-plugins-docker/issues/60

General

[x] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

eheydrick commented 6 years ago

In general looks good modulo @majormoses's concern about extra strings. @epierotto can you include a testing artifact in your PR description showing a before and after the fix.

epierotto commented 6 years ago

@eheydrick Would you mind pointing me out what kind of testing artefact is needed? I'll do my best to fulfil the requirements.

majormoses commented 6 years ago

https://github.com/sensu-plugins/community/blob/master/PULL_REQUEST_PROCESS.md#7-testing-artifacts

epierotto commented 6 years ago

Added output execution to show the current failure and the output with the fix applied.

majormoses commented 6 years ago

I just realized there was another breaking change that was not released yet so I will bundle both fixes in a major version.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-docker/versions/2.0.0