search

sensu-plugins / sensu-plugins-docker

This plugin provides native Docker instrumentation for monitoring and metrics collection, including: container status, container number, and container metrics via `docker ps`.
http://sensu-plugins.io
MIT License
35 stars 57 forks source link

New Regex flag to filter container using Regex String. #69

Open parinapatel opened 5 years ago

parinapatel commented 5 years ago

Pull Request Checklist

Is this in reference to an existing issue? No , but Filter by regex was feature I wanted for quite some time.

General

New Plugins

Purpose

Known Compatibility Issues

majormoses commented 5 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 5 years ago

Overall looks like a great improvement. I took a look at the CI failures, I will work on getting those clean this weekend.

majormoses commented 5 years ago

So the CI failure is caused by https://github.com/ruby/net-telnet/issues/14 where 0.2.0 dropped ruby < 2.3 support. We can pin it for now but I plan on releasing a major shortly after dropping support for the same to cut down on these kinds of issues saving maintainers time and because we also follow the policy of supporting the latest supporting versions of ruby only.

parinapatel commented 5 years ago

its failing for ruby 2.1. @majormoses Would you take a look into it ? I though it was dropping support for ruby 2.3?

majormoses commented 5 years ago

So the problem now was that net-ssh requires at least ruby 2.2:

Fetching: net-ssh-5.0.2.gem (100%)
       /usr/local/lib/ruby/site_ruby/2.1.0/rubygems/installer.rb:611:in `ensure_required_ruby_version_met': net-ssh requires Ruby version >= 2.2.6. (Gem::InstallError)

Honestly at this point ruby < 2.3 is EOL so we should not put too much more effort into that and should just remove support and testing on our end. Here are the things you will want to add, remove, or edit:

In the changelog you will want a section such as this:

### Breaking Changes
- removed support for ruby versions `< 2.3.0` as they are EOL (@yourgithubuser)

This changelog entry should go above your other changes as we want people to first read about breaking changes and then what new features or fixes they want.