Remove ternary true : false - Githubissues

sensu-plugins / sensu-plugins-graphite

This plugin provides native Graphite instrumentation for monitoring, including: replication status, various Graphite data queries, mutators, and handlers

http://sensu-plugins.io

MIT License

22 stars 45 forks source link

Remove ternary true : false #44

Closed baweaver closed 7 years ago

baweaver commented 7 years ago

Adding a ternary to something that returns a boolean is redundant:

[1] pry(main)> true == true
=> true
[2] pry(main)> true == true ? true : false
=> true
[3] pry(main)> true == false ? true : false
=> false
[4] pry(main)> true == false
=> false

Pull Request Checklist

Is this in reference to an existing issue?

General

[ ] Update Changelog following the conventions laid out on Keep A Changelog
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatablity Issues