check-graphite-data, Incorrect behavior if WARN is greater than CRIT

[rayderua]

Hi!

I found that if the WARNING is greater than CRITICAL, then we get the wrong answers.

[/opt/sensu/embedded/bin] ./check-graphite-data.rb -s <SERVER> -t '<TAGGET>' -w 80 -c 70 
TARGET has passed critical threshold (83.468116493418)

should be - OK

[/opt/sensu/embedded/bin] ./check-graphite-data.rb -s <SERVER> -t '<TAGGET>' -w 85 -c 80 
TARGET has passed critical threshold (83.468116493418)

should be - WARNING

[/opt/sensu/embedded/bin] ./check-graphite-data.rb -s <SERVER> -t '<TAGGET>' -w 90 -c 85 
CheckGraphiteData OK: graphite check value OK

should be - CRITICAL

[majormoses]

From the output you show me It is acting as intended for the first two for sure and assuming the numbers from the above this also looks right to me. Critical is a higher level of event type than warning. How would you expect this to work? Maybe I am missing something.

[rayderua]

For example monitoring free space somwhere: 20% free space -warning 10% free space - critical

so 25% - ok, 15% - warning, 5% critical

sometimes impossible to get the metric in another form (% of used instead % free)

Just compare WARN and CRITICAL as in the example below:

if ( CRIT > WARN )
  if ( VALUE  >= CRIT )
    echo "CRITICAL"
  elsif ( VALUE  >= WARN )
    echo "WARNING"
  else
    echo "OK"
  fi
else
  if ( VALUE <= CRIT )
    echo "CRITICAL"
  elsif ( VALUE <= WARN )
    echo "WARNING"
  else
    echo "OK"
  fi
fi

example: check_graphite fro nagios on ruby: https://github.com/obfuscurity/nagios-scripts/blob/master/check_graphite

[majormoses]

I think what you might be looking for something like this:

• https://github.com/sensu-plugins/sensu-plugins-graphite/blob/89e4a9d6c29be0ae65ae20a6f86503997bbf4af1/lib/sensu-plugins-graphite/graphite_proxy/options.rb#L111-L115
• https://github.com/sensu-plugins/sensu-plugins-graphite/blob/eb0c0f3e118c8d0207535ab831469576832b00e4/bin/check-graphite.rb#L81-L85

[majormoses]

or is there something else I am missing

[majormoses]

closing due to inactivity feel free to respond back and we can re-open.