sensu-plugins / sensu-plugins-haproxy

This plugin provides native HAProxy instrumentation for monitoring and metrics collection, including: service health and backend server metrics.

http://sensu-plugins.io

MIT License

11 stars 37 forks source link

Update check-haproxy.rb - comapre sessions to slim, not to smax #40

Closed jindraj closed 4 years ago

jindraj commented 4 years ago

change backends services sessions check comparison to slim instead of smax. Smax is maximum since haproxy start.

Pull Request Checklist

39

General

[x] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
[x] Update README with any necessary configuration snippets
[x] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

Purpose

Known Compatibility Issues

jspaleta commented 4 years ago

Hey! Can you rebase on current master. we have a conflict now due to the robucop changes

jspaleta commented 4 years ago

Also, I think the patch needs to go further there are other usages of smax that probably should be slim

jspaleta commented 4 years ago

I take that last comment back. the remaining smax refs are just informational in the check output.

This looks good.. we just need to fix the conflict with master now

jspaleta commented 4 years ago

i was able to resolve the conflict... we should be able to merge this in and get it into the major release coming out to support Bonsai assets as well

jindraj commented 4 years ago

I'm sorry, I was AFK during the weekend. Thank you for merging the PR. I'm also closing the related issue #39