Update numonly filter to output all Numeric values

sensu-plugins / sensu-plugins-http

This plugin provides native HTTP instrumentation for monitoring and metrics collection, including: response code, JSON response, HTTP last modified, SSL expiry, and metrics via `curl`.

http://sensu-plugins.io

MIT License

30 stars 97 forks source link

Update numonly filter to output all Numeric values #103

Closed korenDevops closed 6 years ago

korenDevops commented 6 years ago

Pull Request Checklist

Is this in reference to an existing issue? Yes, #102

General

[ ] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 6 years ago

https://github.com/sensu-plugins/sensu-plugins-http/pull/103#discussion_r209093664

majormoses commented 6 years ago

I also noticed that upon closer inspection the default was 10 I think thats too high of a default and will change it to 4 unless there is some reason why 10 makes sense.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-http/versions/3.0.0