Fixed A bug where after Sensu plugin v2.1.0 you can nolonger call require 'json' in a sensu-plugin. You need to leverage require 'sensu/json' instead. See - https://github.com/sensu-plugins/sensu-plugin/issues/127

sensu-plugins / sensu-plugins-http

This plugin provides native HTTP instrumentation for monitoring and metrics collection, including: response code, JSON response, HTTP last modified, SSL expiry, and metrics via `curl`.

http://sensu-plugins.io

MIT License

30 stars 97 forks source link

Fixed A bug where after Sensu plugin v2.1.0 you can nolonger call require 'json' in a sensu-plugin. You need to leverage require 'sensu/json' instead. See - https://github.com/sensu-plugins/sensu-plugin/issues/127 #140

Closed bill538 closed 4 years ago

bill538 commented 5 years ago

Pull Request Checklist

Is this in reference to an existing issue? NO

General

[ X] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

jspaleta commented 5 years ago

Hello,

I've implemented and merged a less invasive fix that still let's use use the standard json library.

If you can convince me there is some benefit to using the sensu-json abstraction in the ruby-plugins, I can look to refactor all the check binaries that require 'json'. there are a couple more.

jspaleta commented 4 years ago

Hey, I'm going to go ahead and close this as I implemented a different way to address the problem in a previous release. Please re-open you would like me to reconsider these changes.