search

sensu-plugins / sensu-plugins-http

This plugin provides native HTTP instrumentation for monitoring and metrics collection, including: response code, JSON response, HTTP last modified, SSL expiry, and metrics via `curl`.
http://sensu-plugins.io
MIT License
30 stars 96 forks source link

Get the CI tests working again #60

Closed hartmantis closed 7 years ago

hartmantis commented 7 years ago

Pull Request Checklist

Is this in reference to an existing issue?

I'm not sure who introduced what change, but the test failures were because Sensu's embedded Ruby environment and RVM in TravisCI were stomping on each other's environment variables.

After doing a bunch of test runs in Travis, this seems to be enough to get them going again. And has the added benefit of using RVM's Ruby for the tests, so they cover all the versions of Ruby being tested against.

General

~Update Changelog following the conventions laid out on Keep A Changelog~ ~Update README with any necessary configuration snippets~ ~Binstubs are created if needed~

New Plugins

~Tests~ ~Add the plugin to the README~ ~Does it have a complete header as outlined here~

Purpose

Get the CI build going again.

Known Compatablity Issues

N/A

eheydrick commented 7 years ago

Hey @RoboticCheese, thanks! Nice fix. Looks like sensu-plugins-postfix needs the same treatment.