sensu-plugins / sensu-plugins-http

This plugin provides native HTTP instrumentation for monitoring and metrics collection, including: response code, JSON response, HTTP last modified, SSL expiry, and metrics via `curl`.
http://sensu-plugins.io
MIT License
30 stars 97 forks source link

use rest-client 2.0 to fix issue with OpenSSL 1.1.0 #83

Closed ushis closed 7 years ago

ushis commented 7 years ago

Pull Request Checklist

Fixes #81

General

New Plugins

Purpose

fix

Known Compatibility Issues

none

majormoses commented 7 years ago

@ushis looks like that introduces a breaking change that forces us to drop ruby 2.1 which is still a supported version of ruby so we need to figure out of we can lock this dependency: https://travis-ci.org/sensu-plugins/sensu-plugins-http/jobs/258855032#L561 to keep ruby 2.1 support for this to be accepted. Our official stance is regarding ruby version support: https://github.com/sensu-plugins/documentation/blob/master/docs/FAQ.md#what-is-the-policy-on-supporting-end-of-lifeeol-ruby-versions.

ushi-as commented 7 years ago

@majormoses According to the travis log, this is a problem introduced by kitchen-localhost, not by rest-client.

Gem::InstallError: mixlib-shellout requires Ruby version >= 2.2.
An error occurred while installing mixlib-shellout (2.3.2), and
Bundler cannot continue.
Make sure that `gem install mixlib-shellout -v '2.3.2'` succeeds before
bundling.

In Gemfile:
  kitchen-localhost was resolved to 0.3.0, which depends on
    test-kitchen was resolved to 1.16.0, which depends on
      mixlib-install was resolved to 2.1.12, which depends on
        mixlib-shellout
majormoses commented 7 years ago

@ushi-as ok, can you lock down that down to make it work with ruby 2.1?

ushis commented 7 years ago

@majormoses done

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-http/versions/2.6.0