Closed juan-moreno closed 7 years ago
@Juan-Moreno Thanks for finding and proposing a solution! I am really not much of a java guy myself so for my benefit having reviewed issues around this a few times can you give me some output of before and after for both java 7 and 8 in a gist?
@sovaa @rideallday since you have both recently been involved with this can you please review this as well?
@majormoses I'm going to improve the script to select as limit the maximum that HEAP can reach or the current size (as now is calculating)
@majormoses, now with the changes commited:
The gist with output of before and after for both java 7 and 8: https://gist.github.com/Juan-Moreno/84742e7374ae4abeb7f773f55363459e
This looks sane to me I will merge this tomorrow unless someone says that this breaks them. @sovaa @rideallday last chance.
LGTM
This PR resolves: