Resolve Checks are using Current HEAP instead of Max HEAP and BUG in check agnostic JAVA Version

sensu-plugins / sensu-plugins-java

Sensu Java Plugins

http://sensu-plugins.io

MIT License

5 stars 25 forks source link

Resolve Checks are using Current HEAP instead of Max HEAP and BUG in check agnostic JAVA Version #28

Closed juan-moreno closed 7 years ago

juan-moreno commented 7 years ago

This PR resolves:

Issue #26 (Checks are using Current HEAP instead of Max HEAP)
Issue #27 (BUG in check agnostic JAVA Version)

majormoses commented 7 years ago

@Juan-Moreno Thanks for finding and proposing a solution! I am really not much of a java guy myself so for my benefit having reviewed issues around this a few times can you give me some output of before and after for both java 7 and 8 in a gist?

majormoses commented 7 years ago

@sovaa @rideallday since you have both recently been involved with this can you please review this as well?

juan-moreno commented 7 years ago

@majormoses I'm going to improve the script to select as limit the maximum that HEAP can reach or the current size (as now is calculating)

juan-moreno commented 7 years ago

@majormoses, now with the changes commited:

if you do not specify "-l" parameter or "-l" is "current" the behavior is the same as currently, also resolves bug in java8 (agnostic) for check-java-heap-pcnt.sh file
if you specified "-l" with "max" value, the check is calculated with the maximum of HEAP that the process can reach
Add the max that HEAP can reach in metrics scripts.

The gist with output of before and after for both java 7 and 8: https://gist.github.com/Juan-Moreno/84742e7374ae4abeb7f773f55363459e

majormoses commented 7 years ago

This looks sane to me I will merge this tomorrow unless someone says that this breaks them. @sovaa @rideallday last chance.

sovaa commented 7 years ago

LGTM

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-java/versions/1.3.0