Adding authentication to Jenkins instance

sensu-plugins / sensu-plugins-jenkins

This plugin provides native Jenkins instrumentation for monitoring and metrics collection, including: health, job status, metrics via `JQS`, and others.

http://sensu-plugins.io

MIT License

9 stars 18 forks source link

Adding authentication to Jenkins instance #15

Closed seth-paxton closed 7 years ago

seth-paxton commented 7 years ago

Pull Request Checklist

Issue #14

General

[ ] Update Changelog following the conventions laid out on Keep A Changelog
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass
New Plugins
[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here
Purpose

Known Compatablity Issues

sstarcher commented 7 years ago

Can you change the password passing to be via environment variable

seth-paxton commented 7 years ago

I added the default value to be an ENV. Also modified the description to use an ENV variable. This is the convention I have seen in other plugins. Let me know if this works. Thanks!

sensu-plugins / sensu-plugins-jenkins

Adding authentication to Jenkins instance #15

Pull Request Checklist

General

New Plugins

Purpose

Known Compatablity Issues