search

sensu-plugins / sensu-plugins-jenkins

This plugin provides native Jenkins instrumentation for monitoring and metrics collection, including: health, job status, metrics via `JQS`, and others.
http://sensu-plugins.io
MIT License
9 stars 18 forks source link

Ruby warning #26

Closed gchenuet closed 6 years ago

gchenuet commented 7 years ago

Hi,

When using check-jenkins-job-status.rbcheck, i received ruby warning message about rbreadline:

/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/rb-readline-0.5.3/lib/rbreadline.rb:13: warning: constant ::Fixnum is deprecated

About the setting:

Could you fix it please ?

Thanks

majormoses commented 6 years ago

It is not coming from the plugin code itself but rather from the gem rb-readline in version 0.5.3 I see the new version is 0.5.5 so we could try bumping the dependency and see if it's fixed.

majormoses commented 6 years ago

It looks like it is fixed looking at the code, I will PR it.

majormoses commented 6 years ago

@gchenuet can you verify my PR fixes it for you?